From cee73fb885192da41d69acade3b90e91d2209e35 Mon Sep 17 00:00:00 2001
From: Leo dev <klesti.selimay@icloud.com>
Date: Mon, 23 Dec 2024 11:58:21 +0100
Subject: [PATCH] some changes

---
 Cargo.toml |   2 +-
 lib.rs     | 130 +++++++++++------------------------------------------
 2 files changed, 28 insertions(+), 104 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index c6d718e..3c76749 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "osui-element"
-version = "0.1.17"
+version = "0.1.19"
 edition = "2021"
 description = "The element attribute for defining elements in OSUI"
 license = "Apache-2.0"
diff --git a/lib.rs b/lib.rs
index cb43cb8..6a93e58 100644
--- a/lib.rs
+++ b/lib.rs
@@ -1,94 +1,7 @@
 use proc_macro::TokenStream;
+use proc_macro2::Span;
 use quote::quote;
-use syn::{
-    parse::Parser, parse_macro_input, DeriveInput, Fields, GenericParam, ItemFn,
-    Lifetime, LifetimeParam,
-};
-
-#[proc_macro_attribute]
-pub fn element(_args: TokenStream, input: TokenStream) -> TokenStream {
-    let mut ast = parse_macro_input!(input as DeriveInput);
-    let struct_name = &ast.ident;
-
-    // Check if the struct has generics
-    let has_generics = !ast.generics.params.is_empty();
-
-    // If there are no generics, add a lifetime (if necessary)
-    if ast.generics.lifetimes().count() == 0 && !has_generics {
-        ast.generics
-            .params
-            .push(GenericParam::Lifetime(LifetimeParam::new(Lifetime::new(
-                "'a",
-                proc_macro2::Span::call_site(),
-            ))));
-    }
-
-    // Modify the struct fields to include additional fields
-    match &mut ast.data {
-        syn::Data::Struct(ref mut struct_data) => {
-            if let Fields::Named(fields) = &mut struct_data.fields {
-                fields.named.push(
-                    syn::Field::parse_named
-                        .parse2(quote! { pub children: Children })
-                        .unwrap(),
-                );
-                fields.named.push(
-                    syn::Field::parse_named
-                        .parse2(quote! { pub style: Style })
-                        .unwrap(),
-                );
-                fields.named.push(
-                    syn::Field::parse_named
-                        .parse2(quote! { pub id: &'a str })
-                        .unwrap(),
-                );
-                fields.named.push(
-                    syn::Field::parse_named
-                        .parse2(quote! { pub class: &'a str })
-                        .unwrap(),
-                );
-            }
-        }
-        _ => panic!("`element` can only be used with structs"),
-    }
-
-    // Generate the impl block with generics if needed
-    let impl_block = quote! {
-        impl<'a> ElementCore for #struct_name<'a> {
-            fn get_element_by_id(&mut self, id: &str) -> Option<&mut Element> {
-                if let Children::Children(children, _) = &mut self.children {
-                    for elem in children {
-                        if elem.get_id() == id {
-                            return Some(elem);
-                        } else if let Some(e) = elem.get_element_by_id(id) {
-                            return Some(e);
-                        }
-                    }
-                }
-                None
-            }
-
-            fn get_id(&self) -> String {
-                self.id.to_string()
-            }
-
-            fn get_class(&self) -> String {
-                self.class.to_string()
-            }
-
-            fn get_style(&self) -> &Style {
-                &self.style
-            }
-        }
-    };
-
-    let expanded = quote! {
-        #ast
-        #impl_block
-    };
-
-    expanded.into()
-}
+use syn::{parse_macro_input, FnArg, ItemFn, Lifetime, PatIdent, PatType, Type, TypeReference};
 
 #[proc_macro_attribute]
 pub fn component(_args: TokenStream, input: TokenStream) -> TokenStream {
@@ -101,30 +14,41 @@ pub fn component(_args: TokenStream, input: TokenStream) -> TokenStream {
         syn::ReturnType::Default => syn::parse_quote! { Element },
         syn::ReturnType::Type(_, t) => t,
     };
+    let mut fn_lifetime = false;
 
-    let struct_fields = input_fn.sig.inputs.iter().filter_map(|arg| {
-        if let syn::FnArg::Typed(pat_type) = arg {
-            if let syn::Pat::Ident(pat_ident) = *pat_type.pat.clone() {
-                let field_name = pat_ident.ident;
-                let field_type = pat_type.ty.clone();
-                Some(quote! { pub #field_name: #field_type })
-            } else {
-                None
+    let mut struct_fields = Vec::new();
+
+    for arg in input_fn.sig.inputs.iter() {
+        if let FnArg::Typed(PatType { pat, ty, .. }) = arg {
+            if let syn::Pat::Ident(PatIdent { ident, .. }) = &**pat {
+                let field_name = ident.clone();
+                let mut field_type = *(ty.clone());
+
+                if let Type::Reference(TypeReference { lifetime, .. }) = &mut field_type {
+                    fn_lifetime = true;
+                    *lifetime = Some(Lifetime::new("'a", Span::call_site()));
+                }
+
+                struct_fields.push(quote! { pub #field_name: #field_type });
             }
-        } else {
-            None
         }
-    });
+    }
+
+    let lifetime = if fn_lifetime {
+        quote! {<'a>}
+    } else {
+        quote! {}
+    };
 
     let expanded = quote! {
         #[derive(Debug, Default)]
         #[allow(non_camel_case_types)]
-        #visibility struct #fn_name {
+        #visibility struct #fn_name #lifetime {
             #(#struct_fields),*
         }
 
-        impl Component for #fn_name {
-            fn create_element(&self) -> #return_type {
+        impl #lifetime #fn_name #lifetime {
+            fn create_element(self) -> #return_type {
                 #code
             }
         }