Rename the Ref methods that share a name with vanilla methods #13

2026-09-30T16:01:25Z

selimaj-dev commented

2026-09-30 16:01:25 +00:00

Renames the Ref methods that have the same name and parameters as a method of the vanilla class they're mixed into, so saturnclient's mixins can implement them explicitly:

WindowRef: getWidth/getHeight → getWindowWidth/getWindowHeight. With Mojang's names, Window.getWidth() is the framebuffer's width, so the old name would also have meant the wrong thing.
ItemStackRef: isEmpty/getMaxDamage/getDamage → isEmptyStack/getMaxItemDamage/getItemDamage.

Callers in ImageTexture and ArmorDisplayMod are updated. The saturnclient side (explicit implementations in the mixins, part of the move to Mojang mappings for saturnclient#39) follows once this is merged.

🤖 Generated with Claude Code

Renames the Ref methods that have the same name and parameters as a method of the vanilla class they're mixed into, so saturnclient's mixins can implement them explicitly: - `WindowRef`: `getWidth`/`getHeight` → `getWindowWidth`/`getWindowHeight`. With Mojang's names, `Window.getWidth()` is the framebuffer's width, so the old name would also have meant the wrong thing. - `ItemStackRef`: `isEmpty`/`getMaxDamage`/`getDamage` → `isEmptyStack`/`getMaxItemDamage`/`getItemDamage`. Callers in `ImageTexture` and `ArmorDisplayMod` are updated. The saturnclient side (explicit implementations in the mixins, part of the move to Mojang mappings for saturnclient#39) follows once this is merged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

selimaj-dev added 1 commit 2026-09-30 16:01:25 +00:00

Rename the Ref methods that share a name with vanilla methods a6a324a61a

WindowRef.getWidth/getHeight and ItemStackRef.isEmpty/getMaxDamage
match methods of the classes they're mixed into, so the mixins can't
implement them explicitly. With Mojang's names, Window.getWidth is
also the framebuffer's width rather than the window's. They're now
getWindowWidth/getWindowHeight and isEmptyStack/getMaxItemDamage
(with getItemDamage to match).

Co-Authored-By: Claude Opus 5.5 <[email protected]>

selimaj-dev referenced this pull request from saturnclientmc/saturnclient

2026-09-30 16:02:28 +00:00

Ref methods have no implementation in released jars (AbstractMethodError) #47

selimaj-dev merged commit 653738568a into master

2026-09-30 16:03:45 +00:00

selimaj-dev deleted branch explicit-refs

2026-09-30 16:03:48 +00:00

selimaj-dev referenced this pull request from saturnclientmc/saturnclient

2026-09-30 16:04:13 +00:00

Build every version with Mojang mappings instead of Yarn #49

Sign in to join this conversation.