Playing an emote from the emote wheel doesn't close it in released jars #48

New Issue

2026-09-30T16:02:28Z

selimaj-dev commented

2026-09-30 16:02:28 +00:00

EmoteWheel.play closes the screen through ScreenProvider.close(). SaturnScreenFabric implements that interface method with a close() that also overrides Yarn's Screen.close(). In released jars Loom renames the override to its intermediary name (method_25419), so ScreenProvider.close() has no implementation and throws AbstractMethodError.

The published saturn-client-0.1.4-beta+1.21.11.jar has SaturnScreenFabric.method_25419() and no close(). I haven't reproduced it in a production install.

Fix: SaturnScreenFabric keeps vanilla's onClose() override and implements ScreenProvider.close() separately, calling onClose(). This is on the mojang-mappings branch (#39).

🤖 Generated with Claude Code

`EmoteWheel.play` closes the screen through `ScreenProvider.close()`. `SaturnScreenFabric` implements that interface method with a `close()` that also overrides Yarn's `Screen.close()`. In released jars Loom renames the override to its intermediary name (`method_25419`), so `ScreenProvider.close()` has no implementation and throws `AbstractMethodError`. The published `saturn-client-0.1.4-beta+1.21.11.jar` has `SaturnScreenFabric.method_25419()` and no `close()`. I haven't reproduced it in a production install. Fix: `SaturnScreenFabric` keeps vanilla's `onClose()` override and implements `ScreenProvider.close()` separately, calling `onClose()`. This is on the `mojang-mappings` branch (#39). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

selimaj-dev added the area/emotes area/ui

type

bug

labels 2026-09-30 16:02:33 +00:00

selimaj-dev referenced a pull request that will close this issue

2026-09-30 16:04:13 +00:00

Build every version with Mojang mappings instead of Yarn #49

selimaj-dev closed this issue

2026-09-30 16:17:06 +00:00

selimaj-dev referenced this issue

2026-09-30 20:33:24 +00:00

Bump the version to 0.1.5-beta #53