Service requests have no timeout and can hang forever #5

New Issue

2026-09-25T11:43:40Z

selimaj-dev commented

2026-09-25 11:43:40 +00:00

Problem

None of the ServiceClient requests has a timeout:

getPlayer does a bare session.request(...).join() on the SaturnPlayer-Worker thread
authenticate does session.request(ServiceMethods.Authenticate, ...).get()

If a response never arrives (the session-java send-then-register race, or a server that stopped answering), these block forever:

a stuck getPlayer freezes the player-fetch worker for the rest of the game, so no other player's cosmetics ever load
a stuck authenticate leaves the client unauthenticated without ever logging a failure

Fix

Add a timeout to every request, e.g. .orTimeout(10, TimeUnit.SECONDS) before join() / get(), and handle TimeoutException. For getPlayer, treat a timeout as "unknown, retry later" rather than "not a Saturn user".
Pick up the fixed session-java release once selimaj-dev/session-java#1 lands.

## Problem None of the `ServiceClient` requests has a timeout: - `getPlayer` does a bare `session.request(...).join()` on the `SaturnPlayer-Worker` thread - `authenticate` does `session.request(ServiceMethods.Authenticate, ...).get()` If a response never arrives (the `session-java` send-then-register race, or a server that stopped answering), these block forever: - a stuck `getPlayer` freezes the player-fetch worker for the rest of the game, so no other player's cosmetics ever load - a stuck `authenticate` leaves the client unauthenticated without ever logging a failure ## Fix - Add a timeout to every request, e.g. `.orTimeout(10, TimeUnit.SECONDS)` before `join()` / `get()`, and handle `TimeoutException`. For `getPlayer`, treat a timeout as "unknown, retry later" rather than "not a Saturn user". - Pick up the fixed `session-java` release once selimaj-dev/session-java#1 lands.

selimaj-dev referenced this issue from saturnclientmc/common

2026-09-25 12:46:32 +00:00

Reconnect to the Saturn server and time out requests #2

selimaj-dev referenced this issue from a commit

2026-09-25 12:46:32 +00:00

Reconnect to the Saturn server and time out requests

selimaj-dev referenced this issue

2026-09-25 12:46:46 +00:00

Reconnect to the Saturn server and time out requests (session-java 0.2.0) #10

selimaj-dev referenced this issue from a commit

2026-09-25 12:46:47 +00:00

Use session-java 0.2.0 from the Gitea registry; reconnect and timeouts