saturnclientmc/saturnclient
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 5 Wiki Activity

Fill five version gaps from #30 #32

Merged
selimaj-dev merged 1 commits from version-gaps-small into master 2026-09-27 05:09:21 +00:00
Conversation 0 Commits 1 Files Changed 5
+19 -18
selimaj-dev commented 2026-09-27 04:59:19 +00:00
Owner
Copy Link
Copy Source

Part of #30: the five small gaps. Nametags on 1.21.9+ and the panorama/blur on 1.21.6+ get their own PRs.

Gap Versions Fix
World age (TPS feature, day counter) 1.21.11 World.getTime() was a shortcut for getLevelProperties().getTime(), which every version has. getWorldAge now uses that everywhere, with no version condition. It returned 0 on 1.21.11.
Screen resize 1.21.11 Override the new resize(int, int).
Splash loading-bar border 1.21.9+ drawBorder was renamed drawStrokedRectangle.
Drag deltas in Saturn screens 1.21.9+ mouseDragged(Click, offsetX, offsetY) gets the deltas as offsetX/offsetY (vanilla's Mouse computes them before building the Click). Saturn's screens got 0.0, 0.0.
Role icon in player names 1.21.4–1.21.7 Only storing the player in the render state needs Fabric API's render state data (1.21.8+). The updateRenderState hook now runs on every version, and only the setData call is limited to 1.21.8+. #30 said 1.21.6–1.21.7, but 1.21.4 and 1.21.5 lacked it too.

VERSION_GUIDE.md's TODO examples now point at the two gaps still open.

Checks

  • Builds: compileJava passes for all 8 versions.
  • Switching: round trips on 1.21.4 and 1.21.9 leave src/ unchanged.
  • In game: 1.21.4, 1.21.7 and 1.21.11 start.

Needs an in-game check:

  • the role icon in names on 1.21.4–1.21.7
  • dragging in Saturn screens (sliders, HUD editor) on 1.21.9+
  • the splash border on 1.21.9+
  • resizing the window with a Saturn screen open on 1.21.11
  • the TPS and day counter on 1.21.11

🤖 Generated with Claude Code

Part of #30: the five small gaps. Nametags on 1.21.9+ and the panorama/blur on 1.21.6+ get their own PRs. | Gap | Versions | Fix | |---|---|---| | World age (TPS feature, day counter) | 1.21.11 | `World.getTime()` was a shortcut for `getLevelProperties().getTime()`, which every version has. `getWorldAge` now uses that everywhere, with no version condition. It returned 0 on 1.21.11. | | Screen resize | 1.21.11 | Override the new `resize(int, int)`. | | Splash loading-bar border | 1.21.9+ | `drawBorder` was renamed `drawStrokedRectangle`. | | Drag deltas in Saturn screens | 1.21.9+ | `mouseDragged(Click, offsetX, offsetY)` gets the deltas as `offsetX`/`offsetY` (vanilla's `Mouse` computes them before building the `Click`). Saturn's screens got `0.0, 0.0`. | | Role icon in player names | **1.21.4–1.21.7** | Only storing the player in the render state needs Fabric API's render state data (1.21.8+). The `updateRenderState` hook now runs on every version, and only the `setData` call is limited to 1.21.8+. #30 said 1.21.6–1.21.7, but 1.21.4 and 1.21.5 lacked it too. | `VERSION_GUIDE.md`'s `TODO` examples now point at the two gaps still open. ## Checks - **Builds:** `compileJava` passes for all 8 versions. - **Switching:** round trips on 1.21.4 and 1.21.9 leave `src/` unchanged. - **In game:** 1.21.4, 1.21.7 and 1.21.11 start. **Needs an in-game check:** - the role icon in names on 1.21.4–1.21.7 - dragging in Saturn screens (sliders, HUD editor) on 1.21.9+ - the splash border on 1.21.9+ - resizing the window with a Saturn screen open on 1.21.11 - the TPS and day counter on 1.21.11 🤖 Generated with [Claude Code](https://claude.com/claude-code)
selimaj-dev added 1 commit 2026-09-27 04:59:20 +00:00
Fill five version gaps from #30
Check / compile (pull_request) Successful in 2m31s
Details
48118f6a84 
- World age on 1.21.11: World.getTime() was a shortcut for
  getLevelProperties().getTime(), which every version has, so
  getWorldAge uses that everywhere (the TPS feature and day counter got 0
  on 1.21.11).
- Screen resize on 1.21.11: override resize(int, int), the new signature.
- Splash loading-bar border on 1.21.9+: drawBorder was renamed
  drawStrokedRectangle.
- Drag deltas on 1.21.9+: mouseDragged(Click, offsetX, offsetY) gets the
  deltas as offsetX/offsetY; Saturn's screens got 0.0 before.
- Role icon in player names on 1.21.4-1.21.7: only storing the player in
  the render state needs Fabric API's render state data (1.21.8+). The
  updateRenderState hook now runs on every version and only the setData
  call is limited to 1.21.8+.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
selimaj-dev added the area/uiarea/versions
type
bug
 labels 2026-09-27 04:59:25 +00:00
selimaj-dev merged commit b5ca9dbc8f into master 2026-09-27 05:09:21 +00:00
selimaj-dev deleted branch version-gaps-small 2026-09-27 05:09:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/build
Gradle, Loom, CI, publishing
 area/cosmetics
Cloaks, hats and other cosmetics
 area/emotes
Emote library and emotes in the client
 area/mods
Built-in mods (HUD mods, features)
 area/rendering
Models, shaders, render pipeline
 area/server
Backend, auth, relay
 area/ui
Menus, screens, HUD, theme
 area/versions
Minecraft version support and ports
 good first issue
Small and self-contained
 status/blocked
Waiting on something else
 status/in-progress
Being worked on
 status/needs-info
Needs more details or a decision
priority
critical
Breaks the client or blocks a release
priority
high
Next up
priority
low
Whenever there's time
priority
medium
Soon
type
bug
Something is broken
type
chore
Build, dependencies, tooling, releases
type
docs
Documentation
type
enhancement
Improves something that already exists
type
feature
New functionality
type
refactor
Code change without behaviour change
No labels area/ui area/versions
type
bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
selimaj-dev (Klesti Selimaj)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: saturnclientmc/saturnclient#32